Skip to content

Ensure document stays consistent with y.js state file #5477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 2 commits into from
Mar 20, 2024
Merged

Ensure document stays consistent with y.js state file #5477

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e268115
fix: Clean up logic to return document state file or file content
juliusknorr Mar 13, 2024
a63daee
fix: Set base version etag to a unique id per document creation
juliusknorr Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Set base version etag to a unique id per document creation 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr @mejo-
juliusknorr authored and mejo- committed Mar 20, 2024
commit a63daee740aabc5d5be49f24aa443ed14856daf9
2 changes: 1 addition & 1 deletion lib/Service/DocumentService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public function createDocument(File $file): Document {
$document->setLastSavedVersion(0);
$document->setLastSavedVersionTime($file->getMTime());
$document->setLastSavedVersionEtag($file->getEtag());
$document->setBaseVersionEtag($file->getEtag());
$document->setBaseVersionEtag(uniqid());
try {
/** @var Document $document */
$document = $this->documentMapper->insert($document);
Expand Down