fix(attachments): Don't use currentSession for fetching attachments #5484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
When switching pages in Collectives, `currentSession` might still be the session from the last page. The readonly view (`MarkdownContentEditor`) doesn't get a session, so the outdated session is used. Instead, always pass the session from `AttachmentResolver` to `setAttachmentList`. Fixes: nextcloud/collectives#1096 Fixes: nextcloud/collectives#1112 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/attachments_session
branch
from
8b864cb to
201a363
Compare
grnd-alt
approved these changes
Mar 14, 2024
Member
grnd-alt
left a comment
grnd-alt
left a comment
There was a problem hiding this comment.
went through the changes and tested locally. Working as expected 💯
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching pages in Collectives,
currentSessionmight still be the session from the last page. The readonly view (MarkdownContentEditor) doesn't get a session, so the outdated session is used.Instead, always pass the session from
AttachmentResolvertosetAttachmentList.Fixes: nextcloud/collectives#1096
Fixes: nextcloud/collectives#1112
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)