Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(MarkdownContentEditor): Respect onLoaded callback passed via API
Emit `ready` once the editor is ready (Tiptap `create` event), which
causes the `onLoaded` callback passed via editor API to be called

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
mejo- committed Mar 14, 2024
commit d529e39a5ced6c33061ba1f6182b229de2a967a7
26 changes: 23 additions & 3 deletions src/components/Editor/MarkdownContentEditor.vue
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,15 @@ export default {
extensions: this.extensions(),
onUpdate: ({ editor }) => {
const markdown = (createMarkdownSerializer(this.$editor.schema)).serialize(editor.state.doc)
this.$root.$emit('update:content', {
this.emit('update:content', {
json: editor.state.doc,
markdown,
})
},
onCreate: ({ editor }) => {
this.$emit('ready')
this.$parent.$emit('ready')
}
})
},

Expand All @@ -160,8 +164,24 @@ export default {
},

outlineToggled(visible) {
this.$emit('outline-toggled', visible)
this.$parent.$emit('outline-toggled', visible)
this.emit('outline-toggled', visible)
},

/**
* Wrapper to emit events on our own and the parent component
*
* The parent might be either the root component of src/editor.js or Viewer.vue which collectives currently uses
*
* Ideally this would be done in a generic way in the src/editor.js API abstraction, but it seems
* that there is no proper way to pass any received event along in vue, the only option I've found
* in https://github.com/vuejs/vue/issues/230 feels too hacky to me, so we just emit twice for now
*
* @param {string} event The event name
* @param {any} data The data to pass along
*/
emit(event, data) {
this.$emit(event, data)
this.$parent?.$emit(event, data)
},
},
}
Expand Down