Skip to content

fix(sync): If baseVersionEtag changed, reset frontend #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 6 commits into from
Mar 20, 2024
Merged

fix(sync): If baseVersionEtag changed, reset frontend #5523

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
670d2f8
fix(sync): If `baseVersionEtag` changed, reset frontend
mejo- Mar 15, 2024
f61fb6f
fix(Middleware): Response with 412 if `baseVersionEtag` doesn't match
mejo- Mar 18, 2024
f3439d7
fix(DocumentStatus): Refactor and migrate to `NcNoteCard`
mejo- Mar 18, 2024
fc604e2
test(cypress): Add session API tests with non-matching baseVersionEtag
mejo- Mar 20, 2024
a4e8747
text(cypress): Test browser refresh warning after document session cl…
mejo- Mar 20, 2024
ec4dc16
fix(response): Make sure JSONResponse returns valid data
mejo- Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
text(cypress): Test browser refresh warning after document session cl… 
…eanup

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Mar 20, 2024
commit a4e8747447f3a616d494218dd0d419c3a430f66e
19 changes: 19 additions & 0 deletions cypress/e2e/sync.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,25 @@ describe('Sync', () => {
.should('include', 'after the lost connection')
})

it('shows warning when document session got cleaned up', () => {
cy.get('.save-status button')
.click()
cy.wait('@save')
cy.uploadTestFile('test.md')

cy.get('#editor-container .document-status', { timeout: 30000 })
.should('contain', 'Editing session has expired.')

// Reload button works
cy.get('#editor-container .document-status a.button')
.contains('Reload')
.click()

cy.getContent()
cy.get('#editor-container .document-status .notecard')
.should('not.exist')
})

it('passes the doc content from one session to the next', () => {
cy.closeFile()
cy.intercept({ method: 'PUT', url: '**/apps/text/session/*/create' })
Expand Down