Skip to content

fix(files): Change icons+wording for adding text doc and folder description #5540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 4 commits into from
Mar 21, 2024
Merged

fix(files): Change icons+wording for adding text doc and folder description #5540

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4f82eb
fix(files): Change icons+wording for adding text doc and folder descr…
mejo- Mar 20, 2024
647645a
feat: Use new icon-add-folder-description
Pytal Mar 20, 2024
6814477
feat: Add icon svg inline for New text file
Pytal Mar 20, 2024
3c61575
test: Update cypress selector
Pytal Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: Update cypress selector 
Signed-off-by: Christopher Ng <[email protected]>
  • Loading branch information
@Pytal @juliusknorr
Pytal authored and juliusknorr committed Mar 21, 2024
commit 3c615757adb175b5c7c71b776c9276783f73270d
2 changes: 1 addition & 1 deletion cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ Cypress.Commands.add('createDescription', () => {

cy.get('[data-cy-files-list] tr[data-cy-files-list-row-name="Readme.md"]').should('not.exist')
cy.get('[data-cy-upload-picker] button.action-item__menutoggle').click()
cy.get('li.upload-picker__menu-entry button').contains('Add description').click()
cy.get('li.upload-picker__menu-entry button').contains('Add folder description').click()

cy.wait('@addDescription')
})
Expand Down