Skip to content

[stable29] fix(imageview): Don't try to load unresolved images #5656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Apr 11, 2024
Merged

[stable29] fix(imageview): Don't try to load unresolved images #5656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(imageview): Don't try to load unresolved images 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen @backportbot
nickvergessen authored and backportbot[bot] committed Apr 11, 2024
commit 6f2fa1e2abbc2596ec47b5a8156905914179e9a8
3 changes: 3 additions & 0 deletions src/nodes/ImageView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,9 @@ export default {
methods: {
async loadPreview() {
this.attachment = await this.$attachmentResolver.resolve(this.src)
if (!this.attachment.previewUrl) {
throw new Error('Attachment source was not resolved')
}
return new Promise((resolve, reject) => {
const img = new Image()
img.onload = async () => {
Expand Down