Skip to content

remove old link when editing #5690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grnd-alt merged 9 commits into from
Mar 20, 2025
Merged

remove old link when editing #5690

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9fbd73b
remove old link when editing
grnd-alt Apr 15, 2024
2b1ce9a
refactor(links): add insertOrSetLink command
max-nextcloud Apr 17, 2024
ed3a6d8
refactor(cy): move Links.spec.js into e2e folder
max-nextcloud Apr 17, 2024
3c7aee6
test(cy): initial test for the link mark
max-nextcloud Apr 17, 2024
6539ff7
test(cy): adjust import path in moved Links.spec.js
max-nextcloud Apr 17, 2024
c1ef403
refactor(link): use isMarkActive in insertOrSetLink
max-nextcloud Apr 17, 2024
819ea95
fix: replace link correctly
grnd-alt Feb 11, 2025
0c3bcad
fix: dont overwrite other link commands
grnd-alt Mar 10, 2025
08a528b
use snapshots for long test results
grnd-alt Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove old link when editing 
Signed-off-by: grnd-alt <[email protected]>
  • Loading branch information
@grnd-alt
grnd-alt committed Mar 19, 2025
commit 9fbd73bf855ad40ba7937bca02bf6865bb5bb1b7
3 changes: 3 additions & 0 deletions src/components/Menu/ActionInsertLink.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@ export default {
const chain = this.$editor.chain()
// Check if any text is selected, if not insert the link using the given text property
if (this.$editor.view.state?.selection.empty) {
if (this.state.active) {
chain.deleteNode('paragraph')
}
chain.insertContent({
type: 'paragraph',
content: [{
Expand Down