[stable29] fix(description): 5688 no need to encode filename #5719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
approved these changes
Apr 22, 2024
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
backport looks good. Let's wait for freeze to be over and see what the tests say.
Collaborator
|
Downloading cypress failed for cypress component tests and jest. For jest we should set an env variable that prevents the cypress download. I think these downloads might fail because we are using an older version of cypress that is downloaded less often and maybe missing from some caches or so. |
2 tasks
juliusknorr
approved these changes
Apr 23, 2024
Signed-off-by: Max <[email protected]>
juliusknorr
force-pushed
the
backport/5716/stable29
branch
from
a5c1af4 to
c897dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #5716