fix: Ignore pushes of update steps for read only sessions #5895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
7 tasks
max-nextcloud
approved these changes
Jun 13, 2024
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Did not test - but code looks good.
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
8 tasks
Member
Author
|
/backport to stable27 |
|
The backport to # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b backport/5895/stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 672d3a8f
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5895/stable27Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My suggestion for now would be to block any update steps for read only sessions according to what is described in the y.js protocol docs.
https://github.com/yjs/y-protocols/blob/master/PROTOCOL.md#handling-read-only-users
Ideally we'd of course also prevent sending those in the frontend code, but for now this seems the most reasonable quick fix.