perf: Cache workspace content for propfinds #5948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
perf/cache-workspace-result
branch
from
733ffaa to
e2e1f3e
Compare
mejo-
approved these changes
Jun 26, 2024
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Code changes look good to me.
I just wonder how often it happens that the same folder gets opened again and again in the files app within one hour.
Member
Author
|
It could also be mobile clients sending a propfind with the rich workspace property and for shared folders, group folders it will also help to cache between users. Likely not a huge improvement but might still contribute to less time spent on storage operations. |
come-nc
reviewed
Aug 1, 2024
Comment on lines
+105
to
+106
| } catch (GenericFileException|NotPermittedException|LockedException $e) { | ||
| } |
Contributor
There was a problem hiding this comment.
This should be logged at least in debug, no?
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading a file from disk or possibly remote storage can be costly. We can store the content in cache with the (fileId, etag) as key so we only return the result as long as the file content is unchanged.