Skip to content

[stable29] fix(LinkBubble): Don't open bubble at initialization and on remote changes #5949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 7 commits into from
Jun 26, 2024
Merged

[stable29] fix(LinkBubble): Don't open bubble at initialization and on remote changes #5949

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e77f4de
fix(LinkBubble): Don't open bubble when initializing the editor
mejo- Jun 18, 2024
c7daca8
fix(LinkBubble): Don't open bubble on changes by other session members
mejo- Jun 19, 2024
5a03c9c
test(cypress): Fix initial content undo test
mejo- Jun 19, 2024
1d42d22
fix(LinkBubble): Fix race condition between hide and update
mejo- Jun 25, 2024
b9b2003
chore(LinkBubble): remove superfluous checks
mejo- Jun 25, 2024
07255b1
fix(LinkBubble): Hide link bubble when removing a link
mejo- Jun 25, 2024
fbb21f2
test(cypress): Remove superfluous `cy.get()`
mejo- Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(LinkBubble): Don't open bubble on changes by other session members 
Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo- @backportbot
mejo- authored and backportbot[bot] committed Jun 25, 2024
commit c7daca8e2260cdda6c58404032de22715834e17e
12 changes: 9 additions & 3 deletions src/plugins/links.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,17 @@ export function linkBubble(options) {
}),

appendTransaction: (transactions, oldState, state) => {
// Don't open bubble at editor initialisation
if (oldState?.doc.content.size === 2) {
return
}

// Don't open bubble if neither selection nor doc changed
const sameSelection = oldState?.selection.eq(state.selection)
const sameDoc = oldState?.doc.eq(state.doc)
// Prevent bubble from opening at editor initialisation
const initLoad = oldState?.doc.content.size === 2
if (initLoad || (sameSelection && sameDoc)) {
// Don't open bubble on changes by other session members
const noHistory = !transactions.some(tr => tr.meta.addToHistory)
if (sameSelection && (noHistory || sameDoc)) {
return
}
const active = activeLinkFromSelection(state)
Expand Down