Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 26, 2024

To open a revert right afterwards to not forget, but for now this should not block us from passing CI for easier merges

@juliusknorr juliusknorr added tests If you write them we ♥ you 3. to review labels Jun 26, 2024
@juliusknorr
Copy link
Member Author

Planned to skip the other on as well but noticed @mejo- is looking into that right now in #5951

@juliusknorr
Copy link
Member Author

/backport to stable29

@juliusknorr
Copy link
Member Author

/backport to stable28

@juliusknorr
Copy link
Member Author

/backport to stable27

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Only needs backport to stable29 though.

@mejo-
Copy link
Member

mejo- commented Jun 26, 2024

The failing workspace test should be fixed instead, it's not related to the electron crashes.

@juliusknorr juliusknorr merged commit 533a724 into main Jun 26, 2024
@juliusknorr juliusknorr deleted the ci/skip-crashing-test branch June 26, 2024 13:15
@backportbot
Copy link

backportbot bot commented Jun 26, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/5952/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2622db67

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5952/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review tests If you write them we ♥ you

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants