Skip to content

perf(rich_workspace): only add property for parent #5963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShGKme wants to merge 3 commits into
base: main
Choose a base branch
from
Open

perf(rich_workspace): only add property for parent #5963

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74f6862
perf(rich_workspace): only add property for parent
ShGKme Jun 27, 2024
0517913
test(rich_workspace): never add rich workspace property to nesteds
ShGKme Jun 28, 2024
be1604f
fix: Add extra property to fetch only the top most workspace
juliusknorr Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(rich_workspace): never add rich workspace property to nesteds 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
  • Loading branch information
@ShGKme @juliusknorr
ShGKme authored and juliusknorr committed Apr 11, 2025
commit 0517913fd3b3e44f9c7cb8dd587bf189cc270b0e
6 changes: 2 additions & 4 deletions cypress/e2e/propfind.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ describe('Text PROPFIND extension ', function() {
.should('have.property', richWorkspace, '')
})

// Android app relies on this when navigating nested folders
it('adds rich workspace property to nested folders', function() {
it('never adds rich workspace property to nested folders', function() {
cy.createFolder('/workspace')
// FIXME: Ideally we do not need a page context for those tests at all
// For now the dashboard avoids that we have failing requests due to conflicts when updating the file
Expand All @@ -52,9 +51,8 @@ describe('Text PROPFIND extension ', function() {
cy.uploadFile('test.md', 'text/markdown', '/workspace/Readme.md')
cy.propfindFolder('/', 1)
.then(results => results.pop().propStat[0].properties)
.should('have.property', richWorkspace, '## Hello world\n')
.should('not.have.property', richWorkspace)
})

})

describe('with workspaces disabled', function() {
Expand Down