fix(attachments): Don't require document session for getting attachments #5979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
In editors with a user or share token we don't want to depend on a document session for fetching attachments. This fixes fetching attachments in editors without a document session but with a user session or share token, e.g. in view mode of the Collectives app. Fixes: nextcloud/collectives#1201 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/attachment_user_no_session
branch
from
691f445 to
c13614b
Compare
juliusknorr
approved these changes
Jul 1, 2024
This was referenced Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In editors with a user or share token we don't want to depend on a document session for fetching attachments.
This fixes fetching attachments in editors without a document session but with a user session or share token, e.g. in view mode of the Collectives app.
Fixes: nextcloud/collectives#1201
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)