fix(ApiService): Catch NotPermittedException and return 404 #6019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas <[email protected]>
Also adjust 404 error message in create api function in case of NotPermittedException. We don't want to distinguish between missing permissions and nonexisting files to not reveal that the file exists. Signed-off-by: Jonas <[email protected]>
Member
Author
|
/backport to stable29 |
juliusknorr
approved these changes
Jul 9, 2024
Member
Author
|
/backport to stable28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Also adjust 404 error message in create api function in case of NotPermittedException. We don't want to distinguish between missing permissions and nonexisting files to not reveal that the file exists.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)