Skip to content

[stable29] Fix/toc without transaction #6116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 9 commits into from
Jul 25, 2024
Merged

[stable29] Fix/toc without transaction #6116

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7758d33
refactor(heading): move css to prosemirror.scss
max-nextcloud Jun 11, 2024
dbc163a
fix: use decorations for heading anchors
max-nextcloud Jun 12, 2024
98520cf
test(cy): test headings without node-view-content
max-nextcloud Jun 13, 2024
460f5a8
fix(editor): only setEditable when needed
max-nextcloud Jun 17, 2024
e5930c2
fix(heading): put anchor in front of cursor and first letter
max-nextcloud Jun 18, 2024
13d3b8f
test(cy): do not wait for push after initialization
max-nextcloud Jun 18, 2024
ce7d9c6
fix(headings): adjust decoration if heading level changes
max-nextcloud Jun 18, 2024
dc2ecd2
fix(headingAnchor): Rebuild decorationSet in case of replacements
mejo- Jul 25, 2024
581c895
fix(css): Use single quotes
mejo- Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(editor): only setEditable when needed 
This will trigger an update event on the editor
which in turn will trigger all update handlers.

Avoid this when not necessary.

Signed-off-by: Max <[email protected]>
  • Loading branch information
@max-nextcloud @mejo-
max-nextcloud authored and mejo- committed Jul 25, 2024
commit 460f5a8d30a3f6fe9cb44d078d73cf265ef9fb09
5 changes: 4 additions & 1 deletion src/components/Editor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,10 @@ export default {
this.document = document

this.syncError = null
this.$editor.setEditable(!this.readOnly)
const editable = !this.readOnly
if (this.$editor.isEditable !== editable) {
this.$editor.setEditable(editable)
}
},

onSync({ steps, document }) {
Expand Down