Skip to content

[stable28] Fix/toc without transaction #6124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 10 commits into from
Jul 29, 2024
Merged

[stable28] Fix/toc without transaction #6124

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
836b557
refactor(heading): move css to prosemirror.scss
max-nextcloud Jun 11, 2024
7819e83
fix: use decorations for heading anchors
max-nextcloud Jun 12, 2024
0fced65
test(cy): test headings without node-view-content
max-nextcloud Jun 13, 2024
deead7e
fix(editor): only setEditable when needed
max-nextcloud Jun 17, 2024
007bae6
fix(heading): put anchor in front of cursor and first letter
max-nextcloud Jun 18, 2024
1ebe7b3
test(cy): do not wait for push after initialization
max-nextcloud Jun 18, 2024
d082bda
fix(headings): adjust decoration if heading level changes
max-nextcloud Jun 18, 2024
6048c7a
fix(headingAnchor): Rebuild decorationSet in case of replacements
mejo- Jul 25, 2024
e448864
fix(css): Use single quotes
mejo- Jul 25, 2024
8a6768a
chore: Add missing trailing comma to please linter
mejo- Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(heading): put anchor in front of cursor and first letter 
This allows typing even at the beginning of the heading
as the cursor now is between the anchor and the first letter.

Signed-off-by: Max <[email protected]>
  • Loading branch information
@max-nextcloud @mejo-
max-nextcloud authored and mejo- committed Jul 29, 2024
commit 007bae69eb2ed53b12ed0c371b9a6073dc82924e
6 changes: 5 additions & 1 deletion src/plugins/headingAnchor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,11 @@ function anchorDecorations(doc, headings) {
* @return {Decoration}
*/
function decorationForHeading(heading) {
return Decoration.widget(heading.offset + 1, anchorForHeading(heading))
return Decoration.widget(
heading.offset + 1,
anchorForHeading(heading),
{ side: -1 },
)
}

/**
Expand Down