Skip to content

feat: Move search highlighting to editor API #6199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elzody merged 10 commits into from
Aug 13, 2024
Merged

feat: Move search highlighting to editor API #6199

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d444c32
feat(search): Move to editor API instead of event bus
elzody Aug 8, 2024
6f678c9
feat(test): add previous match test
elzody Aug 12, 2024
061176b
feat(test): add cypress component test for editor
elzody Aug 12, 2024
713707c
feat(test): load fixture into editor
elzody Aug 12, 2024
a28b08d
feat(test): test highlighting multiple matches
elzody Aug 12, 2024
bf54614
feat(test): test for toggling highlight all
elzody Aug 12, 2024
557753c
feat(test): add tests for moving to next/previous match
elzody Aug 12, 2024
3796097
fix: formatting/jsdoc
elzody Aug 12, 2024
62fcf60
chore: add spdx header to new test file
elzody Aug 12, 2024
944fdb4
fix(test): make sure to only get search decorations
elzody Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(test): make sure to only get search decorations 
Signed-off-by: Elizabeth Danzberger <[email protected]>
  • Loading branch information
@elzody
elzody committed Aug 13, 2024
commit 944fdb4d6917ff1e8f95ef88fadb57ac06e47f6a
14 changes: 7 additions & 7 deletions cypress/component/editor/search.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe('editor search highlighting', () => {
const searchQuery = 'Lorem ipsum dolor sit amet'
editor.commands.setSearchQuery(searchQuery)

const highlightedElements = document.querySelectorAll('span[data-text-el]')
const highlightedElements = document.querySelectorAll('span[data-text-el="search-decoration"]')
expect(highlightedElements).to.have.lengthOf(1)
verifyHighlights(highlightedElements, searchQuery)
})
Expand All @@ -36,7 +36,7 @@ describe('editor search highlighting', () => {
const searchQuery = 'quod'
editor.commands.setSearchQuery(searchQuery)

const highlightedElements = document.querySelectorAll('span[data-text-el]')
const highlightedElements = document.querySelectorAll('span[data-text-el="search-decoration"]')
expect(highlightedElements).to.have.lengthOf(3)
verifyHighlights(highlightedElements, searchQuery)
})
Expand All @@ -47,7 +47,7 @@ describe('editor search highlighting', () => {

// Highlight only first occurrence
editor.commands.setSearchQuery(searchQuery, false)
highlightedElements = document.querySelectorAll('span[data-text-el]')
highlightedElements = document.querySelectorAll('span[data-text-el="search-decoration"]')

expect(highlightedElements).to.have.lengthOf(1)
verifyHighlights(highlightedElements, searchQuery)
Expand All @@ -57,10 +57,10 @@ describe('editor search highlighting', () => {
const searchQuery = 'quod'

editor.commands.setSearchQuery(searchQuery, true)
const allHighlightedElements = document.querySelectorAll('span[data-text-el]')
const allHighlightedElements = document.querySelectorAll('span[data-text-el="search-decoration"]')

editor.commands.nextMatch()
const currentlyHighlightedElement = document.querySelectorAll('span[data-text-el]')
const currentlyHighlightedElement = document.querySelectorAll('span[data-text-el="search-decoration"]')

expect(currentlyHighlightedElement).to.have.lengthOf(1)
expect(allHighlightedElements[1]).to.deep.equal(currentlyHighlightedElement[0])
Expand All @@ -70,10 +70,10 @@ describe('editor search highlighting', () => {
const searchQuery = 'quod'

editor.commands.setSearchQuery(searchQuery, true)
const allHighlightedElements = document.querySelectorAll('span[data-text-el]')
const allHighlightedElements = document.querySelectorAll('span[data-text-el="search-decoration"]')

editor.commands.previousMatch()
const currentlyHighlightedElement = document.querySelectorAll('span[data-text-el]')
const currentlyHighlightedElement = document.querySelectorAll('span[data-text-el="search-decoration"]')

expect(currentlyHighlightedElement).to.have.lengthOf(1)
expect(allHighlightedElements[0]).to.deep.equal(currentlyHighlightedElement[0])
Expand Down