Skip to content

[stable29] Fix reconnecting websocket polyfill and error propagation during push #6205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 5 commits into from
Aug 28, 2024
Merged

[stable29] Fix reconnecting websocket polyfill and error propagation during push #6205

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a7c03f2
fix: Track push errors and do not reset error state if push fails but…
juliusknorr Aug 12, 2024
aaf09b7
fix: Do not reset read only state if sync errors occurred
juliusknorr Aug 12, 2024
e450663
fix: emit onerror for websocket and reopen connection on reconnect at…
juliusknorr Aug 12, 2024
943b55d
fix: Emit error if push fails in other unhandled cases
juliusknorr Aug 12, 2024
6bd8b24
fix: Ensure WebsocketPolyfill always has the latest session state and…
juliusknorr Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Do not reset read only state if sync errors occurred 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr @mejo-
juliusknorr authored and mejo- committed Aug 28, 2024
commit aaf09b7cae34c01b6f6c6e32c4198e8c4a1e1a01
2 changes: 1 addition & 1 deletion src/components/Editor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ export default {
this.document = document

this.syncError = null
const editable = !this.readOnly
const editable = !this.readOnly && !this.hasConnectionIssue
if (this.$editor.isEditable !== editable) {
this.$editor.setEditable(editable)
}
Expand Down