Skip to content

[stable30] fix: Reuse NcAutoCompleteResult, remove code duplication #6313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 2 commits into from
Sep 4, 2024
Merged

[stable30] fix: Reuse NcAutoCompleteResult, remove code duplication #6313

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd5c55e
fix: Reuse NcAutoCompleteResult, remove code duplication
joshtrichards Aug 10, 2024
a3da687
chore: Remove unused AutoCompleteResult.vue
joshtrichards Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Reuse NcAutoCompleteResult, remove code duplication 
Signed-off-by: Josh <[email protected]>
  • Loading branch information
@joshtrichards @backportbot
joshtrichards authored and backportbot[bot] committed Sep 4, 2024
commit cd5c55ebfb7d27e1c88818be24ead1fcb9000187
7 changes: 4 additions & 3 deletions src/components/Suggestion/Mention/MentionList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<template>
<SuggestionListWrapper ref="suggestionList" :command="command" :items="items">
<template #default="{ item, active}">
<AutoCompleteResult :id="item.id"
<NcAutoCompleteResult :id="item.id"
:label="item.label"
icon="icon-user"
source="users"
Expand All @@ -19,12 +19,13 @@
</template>

<script>
import AutoCompleteResult from './AutoCompleteResult.vue'
import { NcAutoCompleteResult } from '@nextcloud/vue'

import SuggestionListWrapper from '../SuggestionListWrapper.vue'

export default {
components: {
AutoCompleteResult,
NcAutoCompleteResult,
SuggestionListWrapper,
},
props: {
Expand Down