Skip to content

[stable30] fix(CodeBlock): Fix visibleFocus and pasting in code blocks #6352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 1 commit into from
Sep 14, 2024
Merged

[stable30] fix(CodeBlock): Fix visibleFocus and pasting in code blocks #6352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(CodeBlock): Fix visibleFocus and pasting in code blocks 
Fixes: #5695

The `tabindex` was introduced with commit 2c9e7a0, but I was not able to
reproduce a problem with tab navigation and/or focus trap after removing
it.

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Sep 14, 2024
commit cdeac4370b829f08a92956a9846c011809d10f5b
1 change: 0 additions & 1 deletion src/nodes/CodeBlockView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
<div :class="{'split-view': showCode && showPreview }">
<pre v-show="showCode" class="split-view__code"><NodeViewContent spellcheck="false"
as="code"
tabindex="-1"
:contenteditable="isEditable" /></pre>
<div v-show="showPreview"
ref="preview"
Expand Down