fix(paragraph): migrate preview options to decorations #6425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Render the preview options as a decoration for previews too. Signed-off-by: Max <[email protected]>
Fixes: #6185 Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Required for implementing `deleteNode` like tiptap does it: https://github.com/ueberdosis/tiptap/blob/develop/packages/core/src/NodeView.ts#L305 Signed-off-by: Max <[email protected]>
mejo-
force-pushed
the
fix/paragraph-node-view-to-decorations
branch
from
9a078ec to
93d545f
Compare
max-nextcloud
approved these changes
Sep 18, 2024
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Just a minor nitpick.
Collaborator
|
Oh... did you manage to fix that function that checked if the decorations can be mapped or need to be recomputed? |
mejo-
force-pushed
the
fix/paragraph-node-view-to-decorations
branch
from
56ab0e9 to
7628e9f
Compare
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Compute the range based on offset and nodeSize. Signed-off-by: Max <[email protected]>
- center align options for text links - top align options for preview links Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Otherwise the overlay container would catch all the click events. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
* Don't calculate preview options decorations in readonly editor * Check for changed nodeSize when checking for decoration changes * Rename `editor` to `$editor` in vue compontent, it's not reactive Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/paragraph-node-view-to-decorations
branch
from
7628e9f to
5d61e84
Compare
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)