Skip to content

[stable30] fix(paragraph): migrate preview options to decorations #6431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 13 commits into from
Sep 23, 2024
Merged

[stable30] fix(paragraph): migrate preview options to decorations #6431

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
90a6b13
enh: add extractLinkParagraphs
max-nextcloud Sep 17, 2024
5bb8981
refactor(test): reuse link string
max-nextcloud Sep 17, 2024
88716d9
enh(preview): include previews in list of link paragraphs
max-nextcloud Sep 17, 2024
9eb06cc
feat(previewOptions): Migrate preview options to prosemirror decorations
mejo- Sep 17, 2024
9e0619b
chore(preview): Remove PreviewOptions from Paragraph and Preview
mejo- Sep 17, 2024
2f2660b
enh(preview): add nodeSize in decoration data structure
max-nextcloud Sep 17, 2024
6f824bf
fix(preview): use deleteRange to remove the node
max-nextcloud Sep 17, 2024
cf3de35
fix(preview): Fix alignment of preview options
mejo- Sep 17, 2024
83c528f
fix(paragraph): get rid of superfluous ParagraphView component
mejo- Sep 17, 2024
7fc2f53
fix(preview): Don't let preview options container overlay paragraph
mejo- Sep 18, 2024
f8076a8
fix(preview): Fix some linting issues
mejo- Sep 18, 2024
4971428
test(cy): Fix selectors for paragraphs in cypress tests
mejo- Sep 18, 2024
500577a
fix(preview): Further improvements
mejo- Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(test): reuse link string 
Signed-off-by: Max <[email protected]>
  • Loading branch information
@max-nextcloud @mejo-
max-nextcloud authored and mejo- committed Sep 23, 2024
commit 5bb8981617ce77fb9a99e5195e3431f026bcaa4c
12 changes: 6 additions & 6 deletions src/tests/plugins/extractLinkParagraphs.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import Link from '../../marks/Link.js'
import { createCustomEditor } from '../helpers.js'

describe('extractLinkParagraphs', () => {
const link = '<a href="https://nextcloud.com">Link</a>'

it('returns an empty array for an empty doc', () => {
const doc = prepareDoc('')
Expand All @@ -16,7 +17,7 @@ describe('extractLinkParagraphs', () => {
})

it('returns paragraphs with a single link', () => {
const content = '<p><a href="https://nextcloud.com">Link</a></p>'
const content = `<p>${link}</p>`
const doc = prepareDoc(content)
const paragraphs = extractLinkParagraphs(doc)
expect(paragraphs).toEqual([
Expand All @@ -25,7 +26,7 @@ describe('extractLinkParagraphs', () => {
})

it('returns paragraphs with a single link and whitespace', () => {
const content = '<p><a href="https://nextcloud.com">Link</a> </p>'
const content = `<p>${link} </p>`
const doc = prepareDoc(content)
const paragraphs = extractLinkParagraphs(doc)
expect(paragraphs).toEqual([
Expand All @@ -34,7 +35,7 @@ describe('extractLinkParagraphs', () => {
})

it('returns multiple paragraphs with a single link', () => {
const paragraph = '<p><a href="https://nextcloud.com">Link</a></p>'
const paragraph = `<p>${link}</p>`
const content = paragraph + paragraph
const doc = prepareDoc(content)
const paragraphs = extractLinkParagraphs(doc)
Expand All @@ -52,21 +53,20 @@ describe('extractLinkParagraphs', () => {
})

it('ignores paragraphs with text after the link', () => {
const content = '<p><a href="https://nextcloud.com">Link</a> Hello</p>'
const content = `<p>${link} Hello</p>`
const doc = prepareDoc(content)
const paragraphs = extractLinkParagraphs(doc)
expect(paragraphs).toEqual([])
})

it('ignores paragraphs with text before the link', () => {
const content = '<p>bla <a href="https://nextcloud.com">Link</a></p>'
const content = `<p>Hello ${link}</p>`
const doc = prepareDoc(content)
const paragraphs = extractLinkParagraphs(doc)
expect(paragraphs).toEqual([])
})

it('ignores paragraphs with multiple links', () => {
const link = '<a href="https://nextcloud.com">Link</a>'
const content = `<p>${link} ${link}</p>`
const doc = prepareDoc(content)
const paragraphs = extractLinkParagraphs(doc)
Expand Down