fix(sync): Disable browser broadcast #6479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the browser broadcast does not lead to out of sync docs. If a tab fails to send a step over the network it may still distributes it to a different tab / window via the browser broadcast. That other window will include the step in the yjs history without forwarding it to other parties. From that point on all changes in the second tab will depend on the step that other clients did not receive. Therefore these changes will not be applied at other parties. To prevent this scenario disable browser broadcast completely. Signed-off-by: Max <[email protected]>
mejo-
approved these changes
Sep 30, 2024
JuliaKirschenheuter
approved these changes
Sep 30, 2024
Collaborator
Author
|
/backport to stable30 |
Collaborator
Author
|
/backport to stable29 |
Collaborator
Author
|
/backport to stable28 |
Collaborator
Author
|
cypress failures are unrelated. |
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the browser broadcast does not lead to out of sync docs.
If a tab fails to send a step over the network
it may still distributes it to a different tab / window
via the browser broadcast.
That other window will include the step in the yjs history
without forwarding it to other parties.
From that point on all changes in the second tab
will depend on the step that other clients did not receive.
Therefore these changes will not be applied at other parties.
To prevent this scenario disable browser broadcast completely.