Skip to content

[stable29] Fix some JS console errors #6599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 2 commits into from
Nov 7, 2024
Merged

[stable29] Fix some JS console errors #6599

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37a8840
fix(Editor.vue): provide default for injected `isEmbedded`
mejo- Nov 4, 2024
b316c36
fix(assistant): Provide missing properties to Nextcloud Vue components
mejo- Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(assistant): Provide missing properties to Nextcloud Vue components 
Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo- @juliusknorr
mejo- authored and juliusknorr committed Nov 7, 2024
commit b316c36ef38d95666ac24b4a4ff2171fc421acf7
2 changes: 1 addition & 1 deletion src/components/Assistant.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
@replace-content="translateReplace"
@close="hideTranslate" />

<NcModal :show.sync="showTaskList">
<NcModal :show.sync="showTaskList" :name="t('text', 'Assistant results')">
<div class="task-list">
<h4 v-if="tasks.length > 0">
<span class="assistant-bubble">
Expand Down
10 changes: 7 additions & 3 deletions src/components/Modal/Translate.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
-->

<template>
<NcModal size="large" @close="$emit('close')">
<NcModal size="large"
:name="t('text', 'Translate')"
@close="$emit('close')">
<div class="translate-dialog">
<h2>{{ t('text', 'Translate') }}</h2>
<em>{{ t('text', 'To translate individual parts of the text, select it before using the translate function.') }}</em>
Expand All @@ -31,6 +33,7 @@
<NcSelect v-model="fromLanguage"
input-id="fromLanguage"
:placeholder="t('text', 'Select language')"
:aria-label-combobox="t('text', 'Translate from')"
:options="fromLanguages"
:disabled="disableFromLanguageSelect"
:append-to-body="false" />
Expand All @@ -49,6 +52,7 @@
<NcSelect v-model="toLanguage"
input-id="toLanguage"
:placeholder="t('text', 'Select language')"
:aria-label-combobox="t('text', 'Translate to')"
:options="toLanguages"
:disabled="!fromLanguage"
:append-to-body="false" />
Expand Down Expand Up @@ -166,12 +170,12 @@ export default {
},
watch: {
input() {
this.result = null
this.result = ''
this.error = null
this.autosize()
},
toLanguage() {
this.result = null
this.result = ''
this.error = null
},
},
Expand Down