Skip to content

test(cypress): More specific selector for viewer header in links test #6601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Nov 5, 2024
Merged

test(cypress): More specific selector for viewer header in links test #6601

juliusknorr merged 1 commit into from
Nov 5, 2024

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Nov 5, 2024

Fixes failing cypress test "link bubble -> closes the link bubble when clicking elsewhere".

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@mejo-
test(cypress): More specific selector for viewer header in links test
2eacd1b 
Fixes failing cypress test "link bubble -> closes the link bubble when
clicking elsewhere".

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- added bug Something isn't working tests If you write them we ♥ you 3. to review labels Nov 5, 2024
@mejo- mejo- requested a review from juliusknorr November 5, 2024 09:35
@mejo- mejo- self-assigned this Nov 5, 2024
@mejo- mejo- requested a review from max-nextcloud as a code owner November 5, 2024 09:35
@mejo-
Copy link
Member Author

mejo- commented Nov 5, 2024

/backport to stable30

@mejo-
Copy link
Member Author

mejo- commented Nov 5, 2024

/backport to stable29

@mejo- mejo- mentioned this pull request Nov 5, 2024
Merged
@juliusknorr juliusknorr merged commit 9c462e0 into main Nov 5, 2024
61 checks passed
@juliusknorr juliusknorr deleted the fix/cypress_link_viewer_header branch November 5, 2024 16:23
This was referenced Nov 5, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees

@mejo- mejo-

Labels

3. to review bug Something isn't working tests If you write them we ♥ you

Projects

📝 Office team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mejo- @juliusknorr