Skip to content

enh(ui): smart picker button at the start of line #6855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-nextcloud merged 11 commits into from
Jan 22, 2025
Merged

enh(ui): smart picker button at the start of line #6855

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
35296f7
enh(ui): smart picker button at the end of line
max-nextcloud Jan 15, 2025
d5d2503
enh(ui): show smart picker button when cursor is not eol.
max-nextcloud Jan 15, 2025
eaefa84
fix(ui): tab order for smart picker menu
max-nextcloud Jan 15, 2025
72e55ed
fix(type): hand a boolean to close-after-click
max-nextcloud Jan 15, 2025
ceef599
fix(linkBubble): only set client rect if available
max-nextcloud Jan 15, 2025
d4c454e
fix(preview): use $emit and $on instead of editor as prop
max-nextcloud Jan 15, 2025
cea5ddd
fix(menu): display current line menu on loading
max-nextcloud Jan 15, 2025
9fb6e6e
fix(ui): add spacing between smart picker and preview button
max-nextcloud Jan 15, 2025
1d95953
chore: Move to NcButton and add aria-label
juliusknorr Jan 16, 2025
641dda4
fix(currentLineMenu): undefined currentParagraph handling
max-nextcloud Jan 16, 2025
cffe09b
Merge branch 'main' into enh/smartpicker-button
max-nextcloud Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(type): hand a boolean to close-after-click 
Also standardize our use of it.

Signed-off-by: Max <[email protected]>
  • Loading branch information
@max-nextcloud
max-nextcloud committed Jan 15, 2025
commit 72e55ed6c3b71bce1f0b90fdb5ce4eca76421d63
2 changes: 1 addition & 1 deletion src/components/Editor/PreviewOptions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
{{ t('text', 'Show link preview') }}
</NcActionRadio>
<NcActionSeparator />
<NcActionButton close-after-click="true" @click="deleteNode">
<NcActionButton close-after-click @click="deleteNode">
<template #icon>
<DeleteIcon :size="20" />
</template>
Expand Down
7 changes: 3 additions & 4 deletions src/nodes/CodeBlockView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
<NcActionButton v-if="hasCode"
data-cy="copy-code"
:aria-label="t('text', 'Copy code')"
:close-after-click="false"
@click="copyCode">
<template #icon>
<Check v-if="copySuccess" :size="20" />
Expand All @@ -36,19 +35,19 @@

<NcActionSeparator v-if="supportPreview" />

<NcActionButton v-if="supportPreview" :close-after-click="true" @click="viewMode = 'code'">
<NcActionButton v-if="supportPreview" close-after-click @click="viewMode = 'code'">
<template #icon>
<CodeBraces :size="20" />
</template>
{{ t('text', 'Source code') }}
</NcActionButton>
<NcActionButton v-if="supportPreview" :close-after-click="true" @click="viewMode = 'preview'">
<NcActionButton v-if="supportPreview" close-after-click @click="viewMode = 'preview'">
<template #icon>
<Eye :size="20" />
</template>
{{ t('text', 'Diagram') }}
</NcActionButton>
<NcActionButton v-if="supportPreview" :close-after-click="true" @click="viewMode = 'side-by-side'">
<NcActionButton v-if="supportPreview" close-after-click @click="viewMode = 'side-by-side'">
<template #icon>
<ViewSplitVertical :size="20" />
</template>
Expand Down