Skip to content

Conversation

@JuliaKirschenheuter
Copy link
Contributor

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2025-03-21 17-41-19 Screenshot from 2025-03-21 17-36-55

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.85%. Comparing base (1476d05) to head (8766c11).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6983      +/-   ##
==========================================
+ Coverage   51.88%   58.85%   +6.97%     
==========================================
  Files         478      477       -1     
  Lines       40579    35824    -4755     
  Branches      990      989       -1     
==========================================
+ Hits        21054    21085      +31     
+ Misses      19419    14634    -4785     
+ Partials      106      105       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good design wise. I think we could probably omit the emoji picker since mobile keyboards always come with one

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ that was non blocking so approving

@juliusknorr
Copy link
Member

Good design wise. I think we could probably omit the emoji picker since mobile keyboards always come with one

Good point, we should file that as a follow up.

@juliusknorr
Copy link
Member

Restarted cypress

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/6936-Place-menubar-at-the-bottom-on-mobile branch 3 times, most recently from 566a1c7 to 1aa9964 Compare March 25, 2025 08:50
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/6936-Place-menubar-at-the-bottom-on-mobile branch from 1aa9964 to 8766c11 Compare March 25, 2025 09:21
@JuliaKirschenheuter JuliaKirschenheuter merged commit 67e01ed into main Mar 25, 2025
64 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/6936-Place-menubar-at-the-bottom-on-mobile branch March 25, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Place menubar at the bottom on mobile

4 participants