-
Notifications
You must be signed in to change notification settings - Fork 109
fix(files): Place menubar at the bottom on mobile #6983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): Place menubar at the bottom on mobile #6983
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6983 +/- ##
==========================================
+ Coverage 51.88% 58.85% +6.97%
==========================================
Files 478 477 -1
Lines 40579 35824 -4755
Branches 990 989 -1
==========================================
+ Hits 21054 21085 +31
+ Misses 19419 14634 -4785
+ Partials 106 105 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marcoambrosini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good design wise. I think we could probably omit the emoji picker since mobile keyboards always come with one
marcoambrosini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ that was non blocking so approving
Good point, we should file that as a follow up. |
|
Restarted cypress |
566a1c7 to
1aa9964
Compare
Signed-off-by: julia.kirschenheuter <[email protected]>
1aa9964 to
8766c11
Compare
📝 Summary
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)