Skip to content

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Mar 26, 2025

Signed-off-by: julia.kirschenheuter [email protected]

📝 Summary

Add transition to buttons and take buttons away from mobile view

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2025-03-26 16-17-15 Screenshot from 2025-03-26 16-08-44

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.91%. Comparing base (679e48f) to head (591ba00).
Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7030      +/-   ##
==========================================
+ Coverage   51.89%   51.91%   +0.01%     
==========================================
  Files         478      479       +1     
  Lines       40634    40649      +15     
  Branches      990      990              
==========================================
+ Hits        21088    21103      +15     
  Misses      19440    19440              
  Partials      106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JuliaKirschenheuter JuliaKirschenheuter changed the title fix(files): Remove a smart picker button from suggestions bar fix(files): Set a text on buttons within suggestions bar on mobile viewport Mar 27, 2025
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a problem with the layout braking on mobile:

Screen.Recording.2025-03-27.at.10.25.53.mov

@marcoambrosini
Copy link
Member

I think on mobile we should have something like this

Screenshot 2025-03-27 at 10 45 56

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/7024-Set-a-text-on-buttons-within-suggestions-bar-on-mobile-viewport branch from 8492779 to effe548 Compare March 28, 2025 15:36
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/7024-Set-a-text-on-buttons-within-suggestions-bar-on-mobile-viewport branch from effe548 to 591ba00 Compare March 28, 2025 15:53
@JuliaKirschenheuter
Copy link
Contributor Author

@marcoambrosini done as discussed ;)

For testing with switching between desktop and mobile devices: please update a page each time

@JuliaKirschenheuter JuliaKirschenheuter changed the title fix(files): Set a text on buttons within suggestions bar on mobile viewport fix(files): Add transition to buttons and take buttons away from mobile view Mar 28, 2025
@juliusknorr juliusknorr merged commit e4a4847 into main Apr 16, 2025
64 checks passed
@juliusknorr juliusknorr deleted the fix/7024-Set-a-text-on-buttons-within-suggestions-bar-on-mobile-viewport branch April 16, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set a text on buttons within suggestions bar on mobile viewport

4 participants