Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 4, 2025

📝 Summary

CSS assets need to be cleaned if committed.
So adding css/ to the list of directories to clean on build. Also fix some code style issues and remove unneeded dependency.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.86%. Comparing base (c384831) to head (0dfe99c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7073   +/-   ##
=======================================
  Coverage   51.86%   51.86%           
=======================================
  Files         478      478           
  Lines       40709    40709           
  Branches      993      993           
=======================================
  Hits        21112    21112           
  Misses      19492    19492           
  Partials      105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CSS assets need to be cleaned if commited.
So adding `css/` to the list of directories to clean on build.
Also fix some code style issues and remove unneeded dependency.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@mejo- mejo- force-pushed the chore/cleanup-css branch from 9e7e11f to 0dfe99c Compare April 14, 2025 23:47
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @susnux!

@mejo- mejo- merged commit 61eca51 into main Apr 14, 2025
64 checks passed
@mejo- mejo- deleted the chore/cleanup-css branch April 14, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants