Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 4, 2025

📝 Summary

  • module chunking is nowadays done automatically so we can simplify the entry point.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 59.23%. Comparing base (e9ee278) to head (cb62d30).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/main.js 0.00% 6 Missing ⚠️
src/viewer.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7074      +/-   ##
==========================================
+ Coverage   58.97%   59.23%   +0.25%     
==========================================
  Files         482      481       -1     
  Lines       37117    37139      +22     
  Branches     1048     1046       -2     
==========================================
+ Hits        21891    21998     +107     
+ Misses      15124    15039      -85     
  Partials      102      102              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mejo- mejo- force-pushed the chore/cleanup-main branch from 2df1ac7 to e580b99 Compare April 15, 2025 00:02
@mejo-
Copy link
Member

mejo- commented Apr 15, 2025

@susnux failing cypress test seems related.

@juliusknorr juliusknorr force-pushed the chore/cleanup-main branch from e580b99 to ad36779 Compare June 4, 2025 06:06
@juliusknorr
Copy link
Member

Was missing to call the vue constructur, pushed a fix

@max-nextcloud
Copy link
Collaborator

Failing direct editing test still seems likely to be related.

module chunking is nowadays done automatically so we can simplify the
entry point.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the chore/cleanup-main branch from 026a99e to cb62d30 Compare June 21, 2025 13:58
@susnux
Copy link
Contributor Author

susnux commented Jun 21, 2025

Failing direct editing test still seems likely to be related.

rebased, maybe it was just a fluke

@susnux
Copy link
Contributor Author

susnux commented Jun 21, 2025

seems like it, CI is green now

@max-nextcloud max-nextcloud merged commit 97d544e into main Jun 21, 2025
79 of 82 checks passed
@max-nextcloud max-nextcloud deleted the chore/cleanup-main branch June 21, 2025 16:18
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants