-
Notifications
You must be signed in to change notification settings - Fork 110
refactor: cleanup main entry point #7074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7074 +/- ##
==========================================
+ Coverage 58.97% 59.23% +0.25%
==========================================
Files 482 481 -1
Lines 37117 37139 +22
Branches 1048 1046 -2
==========================================
+ Hits 21891 21998 +107
+ Misses 15124 15039 -85
Partials 102 102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2df1ac7 to
e580b99
Compare
|
@susnux failing cypress test seems related. |
e580b99 to
ad36779
Compare
|
Was missing to call the vue constructur, pushed a fix |
ad36779 to
026a99e
Compare
|
Failing direct editing test still seems likely to be related. |
module chunking is nowadays done automatically so we can simplify the entry point. Signed-off-by: Ferdinand Thiessen <[email protected]>
026a99e to
cb62d30
Compare
rebased, maybe it was just a fluke |
|
seems like it, CI is green now |
📝 Summary
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)