Skip to content

Conversation

@luka-nextcloud
Copy link
Contributor

📝 Summary

🚧 TODO

  • Install @nextcloud/prettier-config and eslint-config-prettier
  • Format code with prettier
  • Add flow .github/workflows/lint-prettier.yml
  • Remove flow stylelint

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Apr 7, 2025
@luka-nextcloud luka-nextcloud moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Office team Apr 7, 2025
@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 63.91220% with 559 lines in your changes missing coverage. Please review.

Project coverage is 51.86%. Comparing base (544a4e7) to head (810eb74).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/nodes/Details.js 21.27% 74 Missing ⚠️
src/services/y-websocket.js 1.38% 71 Missing ⚠️
src/services/SyncService.js 0.00% 51 Missing ⚠️
src/services/PollingBackend.js 0.00% 43 Missing ⚠️
src/nodes/Preview.js 32.75% 39 Missing ⚠️
src/extensions/UserColor.js 0.00% 28 Missing ⚠️
src/services/SessionApi.js 3.57% 27 Missing ⚠️
src/nodes/TaskItem.js 29.41% 24 Missing ⚠️
src/nodes/ImageView.vue 4.16% 23 Missing ⚠️
src/views/RichWorkspace.vue 0.00% 19 Missing ⚠️
... and 32 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7087      +/-   ##
==========================================
+ Coverage   51.70%   51.86%   +0.15%     
==========================================
  Files         479      479              
  Lines       40846    41461     +615     
  Branches      993     1004      +11     
==========================================
+ Hits        21121    21504     +383     
- Misses      19620    19852     +232     
  Partials      105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Luka Trovic <[email protected]>
@luka-nextcloud luka-nextcloud merged commit 9876477 into main Apr 18, 2025
69 of 70 checks passed
@luka-nextcloud luka-nextcloud deleted the prettier-setup branch April 18, 2025 14:21
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Office team Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

stylelint broken after migrating from webpack to vite

3 participants