Skip to content

Conversation

@luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Apr 17, 2025

๐Ÿ“ Summary

๐Ÿ–ผ๏ธ Screenshots

๐Ÿš๏ธ Before
image

๐Ÿก After
image
image

๐Ÿ Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@github-project-automation github-project-automation bot moved this to ๐Ÿงญ Planning evaluation (don't pick) in ๐Ÿ“ Office team Apr 17, 2025
@luka-nextcloud luka-nextcloud added the enhancement New feature or request label Apr 17, 2025
@luka-nextcloud luka-nextcloud moved this from ๐Ÿงญ Planning evaluation (don't pick) to ๐Ÿ‘€ In review in ๐Ÿ“ Office team Apr 17, 2025
@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 58.58%. Comparing base (b04381e) to head (13af688).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/components/ViewerComponent.vue 0.00% 30 Missing โš ๏ธ
src/helpers/mime.js 0.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7132      +/-   ##
==========================================
+ Coverage   51.87%   58.58%   +6.71%     
==========================================
  Files         479      478       -1     
  Lines       41567    36802    -4765     
  Branches     1002     1001       -1     
==========================================
- Hits        21561    21560       -1     
+ Misses      19901    15138    -4763     
+ Partials      105      104       -1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@luka-nextcloud luka-nextcloud force-pushed the viewing-e2ee-files branch 2 times, most recently from 0b17f6a to 257fe53 Compare April 28, 2025 15:48
Signed-off-by: Luka Trovic <[email protected]>
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@juliusknorr juliusknorr merged commit a2a1e0d into main May 5, 2025
64 of 66 checks passed
@juliusknorr juliusknorr deleted the viewing-e2ee-files branch May 5, 2025 14:03
@github-project-automation github-project-automation bot moved this from ๐Ÿ‘€ In review to โ˜‘๏ธ Done in ๐Ÿ“ Office team May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Viewing E2EE files

3 participants