Skip to content

Conversation

@luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented May 13, 2025

📝 Summary

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@luka-nextcloud luka-nextcloud added bug Something isn't working 3. to review labels May 13, 2025
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Did you test it? Looks like it would be fairly easy to write a unit test for the TextDocumentCreator. Then we'd have some automated testing.

@luka-nextcloud luka-nextcloud force-pushed the fix-default-file-extension-in-direct-editing branch 2 times, most recently from 87a81e7 to 44520e8 Compare May 14, 2025 09:46
@luka-nextcloud
Copy link
Contributor Author

Code looks good. Did you test it? Looks like it would be fairly easy to write a unit test for the TextDocumentCreator. Then we'd have some automated testing.

Yes, I tested it. Just added unit test for it.

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

php-cs is unhappy and SPDX header is missing on the test file, but otherwise good to merge 👍

@luka-nextcloud luka-nextcloud force-pushed the fix-default-file-extension-in-direct-editing branch from 44520e8 to dde1ab5 Compare May 14, 2025 13:49
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.19%. Comparing base (c527cb0) to head (dde1ab5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7229   +/-   ##
=======================================
  Coverage   52.18%   52.19%           
=======================================
  Files         479      479           
  Lines       41776    41774    -2     
  Branches     1025     1025           
=======================================
  Hits        21802    21802           
+ Misses      19872    19870    -2     
  Partials      102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@luka-nextcloud luka-nextcloud force-pushed the fix-default-file-extension-in-direct-editing branch 2 times, most recently from 209eb11 to 8a2347a Compare May 15, 2025 15:23
@luka-nextcloud luka-nextcloud force-pushed the fix-default-file-extension-in-direct-editing branch from 8a2347a to 8ebe61f Compare May 16, 2025 16:54
@luka-nextcloud luka-nextcloud merged commit 9d79035 into main May 16, 2025
67 checks passed
@luka-nextcloud luka-nextcloud deleted the fix-default-file-extension-in-direct-editing branch May 16, 2025 19:09
@luka-nextcloud
Copy link
Contributor Author

/backport to stable30

@luka-nextcloud
Copy link
Contributor Author

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respect default extension setting in direct editing

4 participants