Skip to content

Conversation

@max-nextcloud
Copy link
Collaborator

  • chore(workflows): update npm-audit-fix
  • chore(workflows): no build in npm-audit-fix

This will prevent failures on the non existing master branch.
Also stop building the js artifacts for the PR.

We build on the integration branch - not in PRs

I wonder if we should rename our `build` script entry
in package.json instead
as that would allow using the original workflow.

Signed-off-by: Max <[email protected]>
@max-nextcloud max-nextcloud requested a review from mejo- as a code owner June 22, 2025 07:00
@max-nextcloud
Copy link
Collaborator Author

I wonder if we should change the build script entry in package.json to some other name instead.
That would turn npm run build --if-present into a noop and remove the need to change these scripts.

@codecov
Copy link

codecov bot commented Jun 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.32%. Comparing base (ef33a6b) to head (c253378).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7347   +/-   ##
=======================================
  Coverage   52.32%   52.32%           
=======================================
  Files         482      482           
  Lines       42043    42043           
  Branches     1049     1049           
=======================================
  Hits        22000    22000           
  Misses      19940    19940           
  Partials      103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mejo- mejo- merged commit 8748214 into main Jun 24, 2025
71 of 73 checks passed
@mejo- mejo- deleted the bump/workflows/npm-audit-fix branch June 24, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants