chore(refactor): save service with new connection #7417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7417 +/- ##
==========================================
+ Coverage 59.43% 59.53% +0.10%
==========================================
Files 492 493 +1
Lines 37347 37386 +39
Branches 1087 1087
==========================================
+ Hits 22196 22257 +61
+ Misses 15045 15023 -22
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mejo-
force-pushed
the
refactor/save_service
branch
from
ae18aa1 to
757411c
Compare
max-nextcloud
approved these changes
Jul 8, 2025
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Looks good! Thanks!
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Parameter `requesttoken` has to be all lowercase. Also adds a cypress test for `saveViaSendBeacon()`. Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
refactor/save_service
branch
from
f837012 to
58ffb0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)