-
Notifications
You must be signed in to change notification settings - Fork 110
Refactor: use separate apis for polling and attachment handling #7446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
3d97d79 to
fc466b5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7446 +/- ##
==========================================
+ Coverage 59.52% 59.61% +0.09%
==========================================
Files 493 494 +1
Lines 37378 37376 -2
Branches 1087 1088 +1
==========================================
+ Hits 22248 22282 +34
+ Misses 15024 14988 -36
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Max <[email protected]>
fc466b5 to
f8e5ceb
Compare
Signed-off-by: Max <[email protected]>
886c6a2 to
7c77f4d
Compare
It handles numbers and leaves out undefined params all by itself. :) Signed-off-by: Max <[email protected]>
f3e78f5 to
889dd69
Compare
|
superseeds #7442 |
mejo-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks for the continuous cleanup efforts ❤️
Uh oh!
There was an error while loading. Please reload this page.