Skip to content

Conversation

@max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented Jul 13, 2025

  • chore(types): type polling backend and notify service
  • refactor(connection): use sync api instead of SessionConnection
  • chore(refactor): use api functions for attachment handling

@max-nextcloud max-nextcloud force-pushed the refactor/upload-with-separate-api branch from 3d97d79 to fc466b5 Compare July 13, 2025 14:16
@codecov
Copy link

codecov bot commented Jul 13, 2025

Codecov Report

Attention: Patch coverage is 73.29193% with 43 lines in your changes missing coverage. Please review.

Project coverage is 59.61%. Comparing base (57d8424) to head (889dd69).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/services/PollingBackend.ts 42.10% 22 Missing ⚠️
src/apis/sync.ts 5.26% 18 Missing ⚠️
src/services/SyncService.ts 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7446      +/-   ##
==========================================
+ Coverage   59.52%   59.61%   +0.09%     
==========================================
  Files         493      494       +1     
  Lines       37378    37376       -2     
  Branches     1087     1088       +1     
==========================================
+ Hits        22248    22282      +34     
+ Misses      15024    14988      -36     
  Partials      106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@max-nextcloud max-nextcloud force-pushed the refactor/upload-with-separate-api branch from fc466b5 to f8e5ceb Compare July 13, 2025 14:22
@max-nextcloud max-nextcloud force-pushed the refactor/upload-with-separate-api branch from 886c6a2 to 7c77f4d Compare July 13, 2025 15:36
It handles numbers and leaves out undefined params all by itself. :)

Signed-off-by: Max <[email protected]>
@max-nextcloud max-nextcloud force-pushed the refactor/upload-with-separate-api branch from f3e78f5 to 889dd69 Compare July 14, 2025 06:50
@max-nextcloud max-nextcloud changed the title refactor/upload with separate api Refactor: use separate apis for polling and attachment handling Jul 14, 2025
@max-nextcloud
Copy link
Collaborator Author

superseeds #7442

@max-nextcloud max-nextcloud marked this pull request as ready for review July 14, 2025 07:12
@max-nextcloud max-nextcloud requested a review from mejo- as a code owner July 14, 2025 07:12
@max-nextcloud max-nextcloud self-assigned this Jul 14, 2025
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for the continuous cleanup efforts ❤️

@max-nextcloud max-nextcloud merged commit d264a64 into main Jul 14, 2025
68 checks passed
@max-nextcloud max-nextcloud deleted the refactor/upload-with-separate-api branch July 14, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants