Skip to content

fix(workspace): fix race condition when loading #7448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-nextcloud merged 1 commit into from
Jul 14, 2025
Merged

fix(workspace): fix race condition when loading #7448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/helpers/files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ export const addMenuRichWorkspace = () => {

let FilesHeaderRichWorkspaceView
let FilesHeaderRichWorkspaceInstance
let latestFolder

export const FilesWorkspaceHeader = new Header({
id: 'workspace',
Expand All @@ -201,6 +202,7 @@ export const FilesWorkspaceHeader = new Header({
return ['files', 'favorites', 'public-share'].includes(view.id)
},
render: async (el, folder) => {
latestFolder = folder
// Import the RichWorkspace component only when needed
if (!FilesHeaderRichWorkspaceView) {
FilesHeaderRichWorkspaceView = (
Expand All @@ -214,9 +216,9 @@ export const FilesWorkspaceHeader = new Header({
console.debug('Destroying existing FilesHeaderRichWorkspaceInstance')
}

const hasRichWorkspace = !!folder.attributes['rich-workspace-file']
const content = folder.attributes['rich-workspace'] || ''
const path = folder.path || ''
const hasRichWorkspace = !!latestFolder.attributes['rich-workspace-file']
const content = latestFolder.attributes['rich-workspace'] || ''
const path = latestFolder.path || ''

// Create a new instance of the RichWorkspace component
FilesHeaderRichWorkspaceInstance = new Vue({
Expand All @@ -232,6 +234,7 @@ export const FilesWorkspaceHeader = new Header({
},

updated(folder) {
latestFolder = folder
if (!FilesHeaderRichWorkspaceInstance) {
console.error('No vue instance found for FilesWorkspaceHeader')
return
Expand Down
Loading