Skip to content

Several link bubble/preview fixes #7474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 7 commits into from
Jul 23, 2025
Merged

Several link bubble/preview fixes #7474

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a0f499f
fix(PreviewOptions): Pass href, so "open in new tab" option is displayed
mejo- Jul 22, 2025
a3a7676
fix(img): Remove global CSS rules for images in prosemirror
mejo- Jul 22, 2025
4bcb03e
fix(links): Add open button to link bubble
mejo- Jul 22, 2025
80a773c
fix(LinkBubble): Read `editor.contentComponent` when it's ready
mejo- Jul 23, 2025
bca4e51
enh(editorAPI): Allow to pass an openLinkHandler to editor
mejo- Jul 23, 2025
77a336f
fix(LinkBubble): Fix preview border overflowing link bubble
mejo- Jul 23, 2025
bb39a2f
test(cy): add test for using "Open link" button in link bubble
mejo- Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(img): Remove global CSS rules for images in prosemirror 
We have a custom node for displaying images anyway.

This fixes the cursor being a pointer in the preview images of preview
links.

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Jul 23, 2025
commit a3a76764acab892102699ce0285df90c3de6f8de
5 changes: 0 additions & 5 deletions src/css/prosemirror.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,11 +183,6 @@ div.ProseMirror {
font-size: var(--default-font-size);
}

img {
cursor: default;
max-width: 100%;
}

hr {
padding: 2px 0;
border: none;
Expand Down