Skip to content

[stable30] Several link bubble/preview fixes #7475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 7 commits into from
Jul 26, 2025
Merged

[stable30] Several link bubble/preview fixes #7475

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0d1ee3b
fix(PreviewOptions): Pass href, so "open in new tab" option is displayed
mejo- Jul 22, 2025
a51a9f5
fix(img): Remove global CSS rules for images in prosemirror
mejo- Jul 22, 2025
cc1b5b4
fix(links): Add open button to link bubble
mejo- Jul 22, 2025
f9d7472
fix(LinkBubble): Read `editor.contentComponent` when it's ready
mejo- Jul 23, 2025
9a2756a
enh(editorAPI): Allow to pass an openLinkHandler to editor
mejo- Jul 23, 2025
0c25143
fix(LinkBubble): Fix preview border overflowing link bubble
mejo- Jul 23, 2025
2a6cf30
test(cy): add test for using "Open link" button in link bubble
mejo- Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test(cy): add test for using "Open link" button in link bubble 
Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Jul 26, 2025
commit 2a6cf30de14d0c79eb464a2de0ec91f1a5c3319c
12 changes: 11 additions & 1 deletion cypress/e2e/nodes/Links.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('test link marks', function() {
cy.get('.link-view-bubble .widget-default', { timeout: 10000 })
.find('.widget-default--name')
.contains('Nextcloud')
.click({ force: true })
.click()
})

it('shows a link preview in the bubble after browsing to link', () => {
Expand All @@ -64,6 +64,16 @@ describe('test link marks', function() {
.contains('Nextcloud')
})

it('open button opens a new tab', () => {
const link = 'https://nextcloud.com/'
cy.insertLine(link)
clickLink(link)

cy.get('.link-view-bubble button[title="Open link"]').click()

cy.get('@winOpen').should('have.been.calledOnce')
})

it('closes the link bubble when clicking elsewhere', () => {
const link = 'https://nextcloud.com/'
cy.insertLine(link)
Expand Down
Loading