Further TextDirection improvements #7513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to iterate over all nodes of the document each time. Upstream PR: amirhhashemi/tiptap-text-direction#23 Signed-off-by: Jonas <[email protected]>
The upstream Tiptap Keymap extension that we don't use (anymore) also provides this. It allows to undo the automatic changes from input rules directly after they got applied by hitting <Backspace>. Unfortunately this doesn't work for nodes that get changed by the TextDirection extension due to a bug, but there's still plenty of input rules where it works, so let's bring it in. Signed-off-by: Jonas <[email protected]>
max-nextcloud
approved these changes
Jul 29, 2025
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Nice. Thanks for including some samples in the tests
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7513 +/- ##
=======================================
Coverage 59.74% 59.74%
=======================================
Files 496 496
Lines 37990 38016 +26
Branches 1120 1120
=======================================
+ Hits 22698 22714 +16
- Misses 15185 15195 +10
Partials 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes styling for details and callouts with RTL script. Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/undo_input_rule
branch
from
b996b4e to
3b81a75
Compare
Member
Author
|
/backport to stable31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
appendTransaction🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)