[stable30] Further TextDirection improvements #7517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to iterate over all nodes of the document each time. Upstream PR: amirhhashemi/tiptap-text-direction#23 Signed-off-by: Jonas <[email protected]>
mejo-
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable30 #7517 +/- ##
============================================
- Coverage 51.67% 51.65% -0.03%
============================================
Files 117 117
Lines 2804 2813 +9
Branches 560 561 +1
============================================
+ Hits 1449 1453 +4
- Misses 1225 1230 +5
Partials 130 130 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The upstream Tiptap Keymap extension that we don't use (anymore) also provides this. It allows to undo the automatic changes from input rules directly after they got applied by hitting <Backspace>. Unfortunately this doesn't work for nodes that get changed by the TextDirection extension due to a bug, but there's still plenty of input rules where it works, so let's bring it in. Signed-off-by: Jonas <[email protected]>
Fixes styling for details and callouts with RTL script. Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
backport/7515/stable30
branch
from
f17aaac to
ab9ddf8
Compare
mejo-
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7515
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.