[stable31] fix(links): do not steal focus on initial loading #7602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `LinkBubbleView` is created and then mounted by `createTooltip` in the `update` function of the `LinkBubblePluginView`. This already happens during the initial rendering as that is the first time the editor content is updated. At this time the `href` is null and therefore `startEdit` is called which in turn sets the focus in the entry field. Instead set `edit` to `true` right away. The behavior of `mod-k` is still inconsistent. In particular it will not focus the link entry if the `href` already was falsy - for example right after the start. Signed-off-by: Max <[email protected]>
backportbot
bot
requested review from
max-nextcloud and
mejo-
as code owners
max-nextcloud
approved these changes
Sep 2, 2025
AndyScherzinger
approved these changes
Sep 2, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable31 #7602 +/- ##
============================================
+ Coverage 51.34% 58.27% +6.92%
============================================
Files 292 291 -1
Lines 41632 36684 -4948
Branches 875 874 -1
============================================
Hits 21378 21378
+ Misses 20133 15186 -4947
+ Partials 121 120 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #7599