Skip to content

Fix: Delete old sessions in cleanup cron #7665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 9 commits into from
Sep 24, 2025
Merged

Fix: Delete old sessions in cleanup cron #7665

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6687601
Fix: Delete old sessions in cleanup cron
benjaminfrueh Sep 20, 2025
10ab5b5
Run cs:fix again for style fixes
benjaminfrueh Sep 20, 2025
d866c00
Add test for deleteOldSessions method
benjaminfrueh Sep 20, 2025
54fb2ef
Add test for deleteOldSessions method
benjaminfrueh Sep 20, 2025
1dc1cba
Only delete sessions with only steps below lastSavedVersion
benjaminfrueh Sep 22, 2025
ebaf60f
Revert "Only delete sessions with only steps below lastSavedVersion"
benjaminfrueh Sep 22, 2025
594bf8b
Rename query-builder variables for consistency
benjaminfrueh Sep 22, 2025
b1afd23
do not delete steps in deleteOldSession()
benjaminfrueh Sep 24, 2025
3665ce7
Updated Test for deleteOldSessions to expect only sessions to be dele…
benjaminfrueh Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
do not delete steps in deleteOldSession() 
Signed-off-by: Benjamin Frueh <[email protected]>
  • Loading branch information
@benjaminfrueh
benjaminfrueh committed Sep 24, 2025
commit b1afd2398b6c7452d986afaf6e21d61722772a32
6 changes: 0 additions & 6 deletions lib/Db/SessionMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,12 +166,6 @@ public function deleteOldSessions(int $ageInSeconds): int {
break;
}

$deleteStepsQb = $this->db->getQueryBuilder();
$deleteStepsQb->delete('text_steps')
->where($deleteStepsQb->expr()->in('session_id', $deleteStepsQb->createParameter('ids'), IQueryBuilder::PARAM_INT_ARRAY))
->setParameter('ids', $sessionIds, IQueryBuilder::PARAM_INT_ARRAY)
->executeStatement();

$deleteSessionsQb = $this->db->getQueryBuilder();
$batchDeleted = $deleteSessionsQb->delete('text_sessions')
->where($deleteSessionsQb->expr()->in('id', $deleteSessionsQb->createParameter('ids'), IQueryBuilder::PARAM_INT_ARRAY))
Expand Down
Loading