Skip to content

[stable31] Fix: Delete old sessions in cleanup cron #7676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 9 commits into from
Sep 24, 2025
Merged

[stable31] Fix: Delete old sessions in cleanup cron #7676

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b310b02
Fix: Delete old sessions in cleanup cron
benjaminfrueh Sep 20, 2025
7792135
Run cs:fix again for style fixes
benjaminfrueh Sep 20, 2025
661dc12
Add test for deleteOldSessions method
benjaminfrueh Sep 20, 2025
3e6b3bf
Add test for deleteOldSessions method
benjaminfrueh Sep 20, 2025
017bd42
Only delete sessions with only steps below lastSavedVersion
benjaminfrueh Sep 22, 2025
a457350
Revert "Only delete sessions with only steps below lastSavedVersion"
benjaminfrueh Sep 22, 2025
8aadb63
Rename query-builder variables for consistency
benjaminfrueh Sep 22, 2025
3e053d2
do not delete steps in deleteOldSession()
benjaminfrueh Sep 24, 2025
715919d
Updated Test for deleteOldSessions to expect only sessions to be dele…
benjaminfrueh Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Updated Test for deleteOldSessions to expect only sessions to be dele… 
…ted, not their steps

Signed-off-by: Benjamin Frueh <[email protected]>
  • Loading branch information
@benjaminfrueh @backportbot
benjaminfrueh authored and backportbot[bot] committed Sep 24, 2025
commit 715919d096b384f9e1e493b81aecc5ba6ea870db
22 changes: 1 addition & 21 deletions tests/unit/Db/SessionMapperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,23 +122,8 @@ public function testDeleteOldSessions() {
'color' => 'ff0000',
]));

// Create steps for old and recent session
$this->stepMapper->insert(Step::fromParams([
'sessionId' => $oldSession->getId(),
'documentId' => 1,
'data' => 'OLD_STEP',
'version' => 1,
]));
$this->stepMapper->insert(Step::fromParams([
'sessionId' => $recentSession->getId(),
'documentId' => 1,
'data' => 'RECENT_STEP',
'version' => 2,
]));

// Verify 2 sessions and 2 steps
// Verify 2 sessions
self::assertCount(2, $this->sessionMapper->findAll(1));
self::assertCount(2, $this->stepMapper->find(1, 0));

// Delete sessions older than 90 days
$threeMonths = 90 * 24 * 60 * 60;
Expand All @@ -149,10 +134,5 @@ public function testDeleteOldSessions() {
$remainingSessions = $this->sessionMapper->findAll(1);
self::assertCount(1, $remainingSessions);
self::assertEquals($recentSession->getId(), $remainingSessions[0]->getId());

// Should have 1 step from recent session remaining
$remainingSteps = $this->stepMapper->find(1, 0);
self::assertCount(1, $remainingSteps);
self::assertEquals($recentSession->getId(), $remainingSteps[0]->getSessionId());
}
}
Loading