Skip to content

chore(DocumentService): Raise log level for SyncStep2 message to error #7695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 1 commit into from
Sep 29, 2025
Merged

chore(DocumentService): Raise log level for SyncStep2 message to error #7695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore(DocumentService): Raise log level for SyncStep2 message to error 
This happens if the client tries to recover from a missing step, which
should not happen anyway. So let's log it as error to get a better
understanding of how often this happens in practice.

Related: #7692

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Sep 29, 2025
commit db3a398d01b4ca53b39d787df5f08338d0b34fdf
8 changes: 4 additions & 4 deletions lib/Service/DocumentService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,19 +230,19 @@ public function addStep(Document $document, Session $session, array $steps, int
$newVersion = $this->insertSteps($document, $session, $stepsToInsert);
}

// By default send all steps the user has not received yet.
// By default, send all steps the user has not received yet.
$getStepsSinceVersion = $version;
if ($stepsIncludeQuery) {
$this->logger->debug('Loading document state for ' . $documentId);
$this->logger->error('Loading document state for ' . $documentId);
try {
$stateFile = $this->getStateFile($documentId);
$documentState = $stateFile->getContent();
$this->logger->debug('Existing document, state file loaded ' . $documentId);
// If there were any queries in the steps send all steps since last save.
// If there were any queries in the steps, send all steps since last save.
$getStepsSinceVersion = $document->getLastSavedVersion();
} catch (NotFoundException $e) {
$this->logger->debug('Existing document, but no state file found for ' . $documentId);
// If there is no state file include all the steps.
// If there is no state file, include all the steps.
$getStepsSinceVersion = 0;
}
}
Expand Down
Loading