Skip to content

Conversation

@max-nextcloud
Copy link
Collaborator

  • chore(test): move yjs test from cypress to vitest
  • chore(test): move search test from cypress to vitest
  • chore(cleanup): drop cypress component tests in ci

@max-nextcloud max-nextcloud requested a review from mejo- as a code owner October 6, 2025 08:53
@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.34%. Comparing base (ac33b1d) to head (41400a5).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/helpers/yjs.ts 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7719      +/-   ##
==========================================
+ Coverage   59.31%   59.34%   +0.03%     
==========================================
  Files         503      503              
  Lines       39258    39212      -46     
  Branches     1130     1142      +12     
==========================================
- Hits        23285    23271      -14     
+ Misses      15865    15833      -32     
  Partials      108      108              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@max-nextcloud max-nextcloud force-pushed the chore/replace-cypress-component-tests branch 2 times, most recently from dabcb2d to 71acff0 Compare October 6, 2025 12:13
@max-nextcloud max-nextcloud force-pushed the chore/replace-cypress-component-tests branch from 71acff0 to 3398967 Compare October 6, 2025 12:14
@max-nextcloud max-nextcloud force-pushed the chore/replace-cypress-component-tests branch from 3398967 to 41400a5 Compare October 6, 2025 12:17
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nitpicking comments, otherwise looks good to me. Thanks a lot for tackling this ❤️

@mejo-
Copy link
Member

mejo- commented Oct 6, 2025

/backport to stable32

@mejo- mejo- merged commit fcd4164 into main Oct 6, 2025
78 of 80 checks passed
@mejo- mejo- deleted the chore/replace-cypress-component-tests branch October 6, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants