Skip to content

[stable32] fix(sync): Apply document state from create request #7756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
max-nextcloud merged 1 commit into from
Oct 10, 2025
Merged

[stable32] fix(sync): Apply document state from create request #7756

max-nextcloud merged 1 commit into from
Oct 10, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Oct 10, 2025

Backport of PR #7755

@mejo- @backportbot
fix(sync): Apply document state from create request
17853ea 
Prevents possible race condition when steps from first sync request got
applied before documentState from first push request (answer to
SyncStep1) arrived.

Signed-off-by: Jonas <[email protected]>
@backportbot backportbot bot requested a review from max-nextcloud as a code owner October 10, 2025 15:50
@backportbot backportbot bot requested a review from max-nextcloud October 10, 2025 15:50
@backportbot backportbot bot requested a review from mejo- as a code owner October 10, 2025 15:50
@backportbot backportbot bot added bug Something isn't working 3. to review feature: sync labels Oct 10, 2025
@backportbot backportbot bot added this to the Nextcloud 32.0.1 milestone Oct 10, 2025
@codecov
Copy link

codecov bot commented Oct 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.28%. Comparing base (1c2cdcb) to head (17853ea).
⚠️ Report is 2 commits behind head on stable32.

Additional details and impacted files 
@@             Coverage Diff              @@
##           stable32    #7756      +/-   ##
============================================
+ Coverage     52.62%   59.28%   +6.65%     
============================================
  Files           504      503       -1     
  Lines         44177    39228    -4949     
  Branches       1137     1136       -1     
============================================
+ Hits          23248    23255       +7     
+ Misses        20820    15865    -4955     
+ Partials        109      108       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@max-nextcloud max-nextcloud merged commit d55ca94 into stable32 Oct 10, 2025
65 checks passed
@max-nextcloud max-nextcloud deleted the backport/7755/stable32 branch October 10, 2025 16:01
@blizzz blizzz mentioned this pull request Oct 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejo- mejo- Awaiting requested review from mejo- mejo- is a code owner

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees

@mejo- mejo-

Labels

3. to review bug Something isn't working feature: sync

Projects

None yet

Milestone

Nextcloud 32.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@max-nextcloud @mejo-