-
Notifications
You must be signed in to change notification settings - Fork 109
Remove unused preview plugin #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Julius Härtl <[email protected]>
|
/backport to stable18 |
|
/compile /js |
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
|
Icon changed
I wondered if we should create some dedicated functions in a library so it's easier to use? I feel like just using css rules that are duplicate seems a bit weird 🤔 |
|
Yep, that is fixed in a separate PR. I think we could even drop that test as for text it should be fine to assume that the viewer does its stuff properly, however I added a case for it back then since we were the only app integrating at that point in time. |
|
The backport to stable18 failed. Please do this backport manually. |
|
/backport 35b2f07 to stable18 |
|
backport to stable18 in #783 with conflicts |
|
/backport 69e0eca to stable18 |
|
The backport to stable18 failed. Please do this backport manually. |
|
/backport 69e0eca to stable18 |
|
backport to stable18 in #784 with conflicts |
The files app does no longer support javascript based preview plugins since Nextcloud 18