-
Notifications
You must be signed in to change notification settings - Fork 109
backport sync fixes to stable31 #7779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove the delegations to only use the typed interface. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
* Hand versions alongside the actual step. * Increase sync service version when processing the next step. * Keep track of the step that is currently processed and provide better `warn` logging when steps are not processed. * Add types to WebsocketPolyfill and its test. Signed-off-by: Max <[email protected]>
Drop the `FlatStep` type. Process each version iterating through its data. Increment the version counter afterwards. Signed-off-by: Max <[email protected]>
* First is logged as error. * Second is logged as debug and can be tracked with conditional logging. Signed-off-by: Jonas <[email protected]> Signed-off-by: Max <[email protected]>
Signed-off-by: Jonas <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable31 #7779 +/- ##
============================================
+ Coverage 50.68% 58.28% +7.59%
============================================
Files 292 290 -2
Lines 42332 36715 -5617
Branches 875 867 -8
============================================
- Hits 21458 21399 -59
+ Misses 20753 15198 -5555
+ Partials 121 118 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prevents possible race condition when steps from first sync request got applied before documentState from first push request (answer to SyncStep1) arrived. Signed-off-by: Jonas <[email protected]>
c2848ea to
d9fe6eb
Compare
Signed-off-by: Max <[email protected]>
mejo-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and didn't manage to break it with three simultaneous session clients.
Backport various sync fixes: